Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16650#discussion_r97887675 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -173,6 +174,24 @@ private[scheduler] class BlacklistTracker ( listenerBus.post(SparkListenerExecutorBlacklisted(now, exec, newTotal)) executorIdToFailureList.remove(exec) updateNextExpiryTime() + // Add executor to blacklist before attempting to kill it. This allows a scheduler backend + // to immediately fail to allocate resources on this executor, since killing could be + // asynchronous. + conf.get(config.BLACKLIST_KILL_ENABLED) match { + case Some(enabled) => + if (enabled) { --- End diff -- Or: ``` case Some(true) => case _ => ``` But having a default in the config is way better.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org