Github user jsoltren commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r98082949
--- Diff:
core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
---
@@ -528,6 +548,16 @@ class StandaloneDynamicAllocationSuite
}
}
+ /** Kill the executors on a given host. */
+ private def killExecutorsOnHost(sc: SparkContext, host: String): Boolean
= {
+ syncExecutors(sc)
+ sc.schedulerBackend match {
+ case b: CoarseGrainedSchedulerBackend =>
+ b.killExecutorsOnHost(host, false)
--- End diff --
Yes, the test was the sole reason for exposing replace, so it can be
removed. I was having some issues with .keySet earlier, and, we do need to
`syncExecutors(sc)` after killing to pass the test. I'm keeping the
`eventually` block since killing happens asynchronously.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
