Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16700#discussion_r98322377
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -899,6 +919,21 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
spec, partitionColumnNames, tablePath)
try {
tablePath.getFileSystem(hadoopConf).rename(wrongPath, rightPath)
+
+ // If the newSpec contains more than one depth partition,
FileSystem.rename just deletes
+ // the leaf(i.e. wrongPath), we should check if wrongPath's
parents need to be deleted.
+ // For example, give a newSpec 'A=1/B=2', after calling Hive's
client.renamePartitions,
+ // the location path in FileSystem is changed to 'a=1/b=2',
which is wrongPath, then
+ // although we renamed it to 'A=1/B=2', 'a=1/b=2' in FileSystem
is deleted, but 'a=1'
+ // is still exists, which we also need to delete
+ val delHivePartPathAfterRename = getExtraPartPathCreatedByHive(
--- End diff --
Hmmm, could it possibly have multiple specs sharing the same parent
directory, e.g., 'A=1/B=2', 'A=1/B=3', ...?
If so, when you delete the path 'a=1' here, in processing the next spec
'A=1/B=3', I think the rename will fail.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
