Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16736#discussion_r98521412
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -464,6 +464,16 @@ object SQLConf {
         .intConf
         .createWithDefault(20)
     
    +  val DATA_SOURCE_TABLE_RELATION_CACHE_MAX_SIZE =
    +    SQLConfigBuilder("spark.sql.sources.tableRelationCache.maxSize")
    --- End diff --
    
    We are having the similar cache size conf. 
    ```Scala
      val HIVE_FILESOURCE_PARTITION_FILE_CACHE_SIZE =
        SQLConfigBuilder("spark.sql.hive.filesourcePartitionFileCacheSize")
    ```
    
    Maybe you can change it to make the naming more consistent. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to