Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16736#discussion_r98589278 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -221,6 +221,19 @@ class SQLConfSuite extends QueryTest with SharedSQLContext { .sessionState.conf.warehousePath.stripSuffix("/")) } + test("DATA_SOURCE_TABLE_RELATION_CACHE_MAX_SIZE") { + assert(spark.conf.get(SQLConf.DATA_SOURCE_TABLE_RELATION_CACHE_MAX_SIZE) === 1000) + withSQLConf(SQLConf.DATA_SOURCE_TABLE_RELATION_CACHE_MAX_SIZE.key -> "2000") { + assert(spark.conf.get(SQLConf.DATA_SOURCE_TABLE_RELATION_CACHE_MAX_SIZE) === 2000) + } --- End diff -- thanks! ah I just saw there had been [discussions about similar issues](https://github.com/apache/spark/pull/15539). right now I don't see needs to change this case's `maxSize` value -- after all disabling the cache causes problems right now thus we cannot do it -- so let's put this config into `StaticSQLConf`? let me push a commit on this.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org