Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16720#discussion_r98837066
  
    --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
    @@ -27,6 +27,9 @@ library(SparkR)
     
     We use default settings in which it runs in local mode. It auto downloads 
Spark package in the background if no previous installation is found. For more 
details about setup, see [Spark Session](#SetupSparkSession).
     
    +```{r, include=FALSE}
    +SparkR:::sparkCheckInstall()
    --- End diff --
    
    Is the Rmd file a part of the install that the users see ? I just dont want 
to put in any code that people might copy-paste etc. Is it not good enough to 
pass in `master=local[*]` here ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to