Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16720#discussion_r99975068
  
    --- Diff: R/pkg/inst/tests/testthat/test_utils.R ---
    @@ -17,6 +17,9 @@
     
     context("functions in utils.R")
     
    +# Ensure Spark is installed
    +sparkCheckInstall()
    --- End diff --
    
    I just tested this by putting SparkR:::checkInstall in run-all.R (before 
calling test_package) and that seems to do the trick on a custom 2.1.0 build ! 
    
    @felixchueng when you get a chance can you update the PR with that ? The 
only thing that I'm concerned about is calling a private function from 
`run-all.R` - We could either export this function or move some of this 
functionality into `install.spark`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to