Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16766#discussion_r99284809
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -2437,9 +2435,12 @@ class Dataset[T] private[sql](
        * @group typedrel
        * @since 1.6.0
        */
    -  def coalesce(numPartitions: Int): Dataset[T] = withTypedPlan {
    -    Repartition(numPartitions, shuffle = false, logicalPlan)
    -  }
    +  def coalesce(numPartitions: Int, partitionCoalescer: 
Option[PartitionCoalescer]): Dataset[T] =
    +    withTypedPlan {
    +      CoalesceLogical(numPartitions, partitionCoalescer, logicalPlan)
    +    }
    +
    +  def coalesce(numPartitions: Int): Dataset[T] = coalesce(numPartitions, 
None)
    --- End diff --
    
    Please also add the function description, like what we did in the other 
functions in Dataset.scala?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to