Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16766#discussion_r99286805 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -117,6 +134,34 @@ class DatasetSuite extends QueryTest with SharedSQLContext { data: _*) } + test("coalesce, custom") { + + val maxSplitSize = 512 + // Similar to the implementation of `test("custom RDD coalescer")` from [[RDDSuite]] we first + // write out to disk, to ensure that our splits are in fact [[FileSplit]] instances. + val data = (1 to 1000).map(i => ClassData(i.toString, i)) + data.toDS().repartition(10).write.format("csv").save(path.toString) --- End diff -- use `WithPath` to generate the path?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org