Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16740
@sethah Thanks for the review. Made changes you suggested (except for the
nit part). I added more tests although I don't think they are really necessary.
The analytical approach is taking a different path from IRWLS, so I agree if we
use it then we should thoroughly test it. But the current fix is just allowing
the existing algorithm to work in a special case, which is well tested in the
more general cases. Anyway, hope we can move close this PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
