Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16787#discussion_r100057282 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala --- @@ -583,11 +468,12 @@ private[spark] object HiveUtils extends Logging { if (DDLUtils.isDatasourceTable(table) || table.schema.nonEmpty) { table } else { - val hiveTable = toHiveTable(table) + val hiveTable = HiveClientImpl.toHiveTable(table) // Note: Hive separates partition columns and the schema, but for us the // partition columns are part of the schema - val partCols = hiveTable.getPartCols.asScala.map(fromHiveColumn) - val schema = StructType(hiveTable.getCols.asScala.map(fromHiveColumn) ++ partCols) + val partCols = hiveTable.getPartCols.asScala.map(HiveClientImpl.fromHiveColumn) + val schema = StructType(hiveTable.getCols.asScala.map(HiveClientImpl.fromHiveColumn) + ++ partCols) table.copy(schema = schema) --- End diff -- nit: ``` val partCols = ... val dataCols = ... table.copy(schema = StructType(dataCols ++ partCols)) ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org