Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r100318189
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int
klen, Object vbase, long voff
assert (vlen % 8 == 0);
assert (longArray != null);
- if (numKeys == MAX_CAPACITY
- // The map could be reused from last spill (because of no enough
memory to grow),
- // then we don't try to grow again if hit the `growthThreshold`.
- || !canGrowArray && numKeys > growthThreshold) {
- return false;
+ if (numKeys >= growthThreshold) {
+ if (longArray.size() / 2 == MAX_CAPACITY) {
--- End diff --
We grow the array when `numKeys >= growthThreshold` and `growthThreshold =
capacity * 0.5`. But we actually allocate `capacity * 2` spaces for the array.
So actually `numKeys < growthThreshold = capacity * 0.5 < array length =
capacity * 2` should hold true.
Because `numKeys < growthThreshold` is always true, if `numKeys ==
MAX_CAPACITY`, the capacity would be `MAX_CAPACITY * 2` at least and the length
of array will be more than `MAX_CAPACITY * 4`.
But in `allocate`, there is an assert of `capacity <= MAX_CAPACITY`. Looks
like those condition are inconsistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
