GitHub user erenavsarogullari opened a pull request:
https://github.com/apache/spark/pull/16905
[SPARK-19567] [CORE] [SCHEDULER] Support some Schedulable variables
immutability and access
## What changes were proposed in this pull request?
Some `Schedulable` Entities(`Pool` and `TaskSetManager`) variables need
refactoring for _immutability_ and _access modifiers_ levels as follows:
- From `var` to `val` (if there is no requirement): This is important to
support immutability as much as possible.
- Sample => `Pool`: `weight`, `minShare`, `priority`, `name` and
`taskSetSchedulingAlgorithm`.
- Access modifiers: Specially, `var`s access needs to be restricted from
other parts of codebase to prevent potential side effects.
- `TaskSetManager`: `tasksSuccessful`, `totalResultSize`,
`calculatedTasks` etc...
This PR is related with #15604 and has been created seperatedly to keep
patch content as isolated and to help the reviewers.
## How was this patch tested?
Added new UTs and existing UT coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/erenavsarogullari/spark SPARK-19567
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16905.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16905
----
commit 6f3ab6eda18239625db8f417e367c83d976eb4b9
Author: erenavsarogullari <erenavsarogull...@gmail.com>
Date: 2017-02-12T20:31:02Z
Support some Schedulable variables immutability and access
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
