Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16905#discussion_r100771562 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala --- @@ -37,25 +37,22 @@ private[spark] class Pool( val schedulableQueue = new ConcurrentLinkedQueue[Schedulable] val schedulableNameToSchedulable = new ConcurrentHashMap[String, Schedulable] - var weight = initWeight - var minShare = initMinShare + val weight = initWeight --- End diff -- These appear to be pretty much redundant then? if they're just set once to another existing variable's value?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org