Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16941#discussion_r101313928
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
 ---
    @@ -505,7 +505,13 @@ class PlanParserSuite extends PlanTest {
         val m2 = intercept[ParseException] {
           parsePlan("SELECT /*+ MAPJOIN(default.t) */ * from default.t")
         }.getMessage
    -    assert(m2.contains("no viable alternative at input"))
    +    assert(m2.contains("mismatched input '.' expecting {')', ','}"))
    +
    +    // Disallow space as the delimiter.
    +    val m3 = intercept[ParseException] {
    --- End diff --
    
    NIT: You can use the `PlanParserSuite.intercept` method. That saves some 
typing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to