Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16941#discussion_r101328119
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
---
@@ -524,7 +530,7 @@ class PlanParserSuite extends PlanTest {
Hint("STREAMTABLE", Seq("a", "b", "c"), table("t").select(star())))
comparePlans(
- parsePlan("SELECT /*+ INDEX(t emp_job_ix) */ * FROM t"),
+ parsePlan("SELECT /*+ INDEX(t, emp_job_ix) */ * FROM t"),
--- End diff --
Hi, @viirya and @cloud-fan @hvanhovell @rxin @gatorsmile .
Just for explanation, it was originally designed to support other syntax
like the followings. Except query block parts (which we don't support), this
case means `tableSpec` and `indexSpec`.
https://docs.oracle.com/cd/B12037_01/server.101/b10752/hintsref.htm#21629
At that time, there was a request to provide more general syntax to prevent
future changes on `SqlBase.g4` layer.
Anyway, I have no objection on the current approach since I also read the
comments between @rxin and @viirya on the previous @rxin 's commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
