Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16970#discussion_r102378293
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ---
    @@ -869,3 +869,12 @@ case object OneRowRelation extends LeafNode {
       override def output: Seq[Attribute] = Nil
       override def computeStats(conf: CatalystConf): Statistics = 
Statistics(sizeInBytes = 1)
     }
    +
    +/** A logical plan for `dropDuplicates`. */
    +case class Deduplication(
    --- End diff --
    
    Most names are like "verbs" - aggregate, project, intersect. I think its 
best to name this "Deduplicate".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to