Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/16970#discussion_r102381390
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1996,7 +1996,7 @@ class Dataset[T] private[sql](
def dropDuplicates(colNames: Seq[String]): Dataset[T] = withTypedPlan {
--- End diff --
You have to add more documentation for streaming usage! especially you have
to document that this will keep all past data as intermediate state, and you
can use the `withWatermark` to limit how late the duplicate data can be and
system will accordingly limit the state.
Also, double the docs on withWatermark and make sure its consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
