Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17001#discussion_r102387112
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -311,11 +313,12 @@ private[hive] class HiveClientImpl(
       override def createDatabase(
           database: CatalogDatabase,
           ignoreIfExists: Boolean): Unit = withHiveState {
    +    // default database's location always use the warehouse path, here set 
to emtpy string
         client.createDatabase(
           new HiveDatabase(
             database.name,
             database.description,
    -        database.locationUri,
    +        if (database.name == SessionCatalog.DEFAULT_DATABASE) "" else 
database.locationUri,
    --- End diff --
    
    If it is empty, metastore will set it for us, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to