Github user windpiger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17001#discussion_r102392451
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -311,11 +313,12 @@ private[hive] class HiveClientImpl(
       override def createDatabase(
           database: CatalogDatabase,
           ignoreIfExists: Boolean): Unit = withHiveState {
    +    // default database's location always use the warehouse path, here set 
to emtpy string
         client.createDatabase(
           new HiveDatabase(
             database.name,
             database.description,
    -        database.locationUri,
    +        if (database.name == SessionCatalog.DEFAULT_DATABASE) "" else 
database.locationUri,
    --- End diff --
    
    sorry, actually it will throw an exception, my local default has created, 
so it does not hit the exception, I will just replace the default database 
location when reload from metastore, drop the logic when create database set 
location to empty string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to