GitHub user dilipbiswal opened a pull request:

    https://github.com/apache/spark/pull/17060

    [SQL] Duplicate test exception in SQLQueryTestSuite due to meta 
files(.DS_Store) on Mac

    ## What changes were proposed in this pull request?
    After adding the tests for subquery, we now have multiple level of 
directories under "sql-tests/inputs".  Some times on Mac while using Finder 
application it creates the meta data files called ".DS_Store". When these files 
are present at different levels in directory hierarchy, we get duplicate test 
exception while running the tests  as we just use the file name as the test 
case name. In this PR, we use the relative file path from the base directory 
along with the test file as the test name. Here is the truncated output of the 
test run after the change. Also after this change, we can have the same test 
file name under different directory like exists/basic.sql , in/basic.sql.
    
    ```SQL
    info] SQLQueryTestSuite:
    [info] - arithmetic.sql (5 seconds, 235 milliseconds)
    [info] - array.sql (536 milliseconds)
    [info] - blacklist.sql !!! IGNORED !!!
    [info] - cast.sql (550 milliseconds)
    ....
    ....
    ....
    [info] - union.sql (315 milliseconds)
    [info] - subquery/.DS_Store !!! IGNORED !!!
    [info] - subquery/exists-subquery/.DS_Store !!! IGNORED !!!
    [info] - subquery/exists-subquery/exists-aggregate.sql (2 seconds, 451 
milliseconds)
    ....
    ....
    [info] - subquery/in-subquery/in-group-by.sql (12 seconds, 264 milliseconds)
    ....
    ....
    [info] - subquery/scalar-subquery/scalar-subquery-predicate.sql (7 seconds, 
769 milliseconds)
    [info] - subquery/scalar-subquery/scalar-subquery-select.sql (4 seconds, 
119 milliseconds)
    ```
    Since this is a simple change, i haven't created a JIRA for it.  
    ## How was this patch tested?
    Manually verified. This is change to test infrastructure
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dilipbiswal/spark sqlquerytestsuite

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17060.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17060
    
----
commit 5f2a6a82244a623fed142555f55dd34060426e5a
Author: Dilip Biswal <dbis...@us.ibm.com>
Date:   2017-02-24T22:28:56Z

    Duplicate test exception

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to