Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/17060#discussion_r103070711 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -241,7 +243,8 @@ class SQLQueryTestSuite extends QueryTest with SharedSQLContext { private def listTestCases(): Seq[TestCase] = { listFilesRecursively(new File(inputFilePath)).map { file => val resultFile = file.getAbsolutePath.replace(inputFilePath, goldenFilePath) + ".out" - TestCase(file.getName, file.getAbsolutePath, resultFile) + val absPath = file.getAbsolutePath + TestCase(absPath.stripPrefix(inputFilePath + File.separator), absPath, resultFile) --- End diff -- @srowen I am adding a separator to make sure the test case name does not have a leading separator character. Example: ``` file = /home/spark/sql/core/src/test/resources/sql-tests/inputs/subquery/exists-subquery/exists-basic.sql inputFilePath = /home/spark/sql/core/src/test/resources/sql-tests/inputs ``` So i wanted the test case name to be `subquery/exists-subquery/exists-basic.sql` and not `/subquery/exists-subquery/exists-basic.sql`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org