Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17083#discussion_r103278713
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -378,7 +378,8 @@ private[spark] object JettyUtils extends Logging {
server.getHandler().asInstanceOf[ContextHandlerCollection])
}
- private def createRedirectHttpsHandler(securePort: Int, scheme: String):
ContextHandler = {
+ private def createRedirectHttpsHandler(
+ httpsConnector: ServerConnector, scheme: String): ContextHandler = {
--- End diff --
nit: one argument per line when using multiple lines.
But instead of changing this, why not pass the correct port from the caller
in the first place?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
