Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17083#discussion_r104064675
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
    @@ -330,7 +330,7 @@ private[spark] object JettyUtils extends Logging {
     
               // redirect the HTTP requests to HTTPS port
               httpConnector.setName(REDIRECT_CONNECTOR_NAME)
    -          collection.addHandler(createRedirectHttpsHandler(securePort, 
scheme))
    +          collection.addHandler(createRedirectHttpsHandler(connector, 
scheme))
    --- End diff --
    
    @vanzin , AFAIK in this code, at that time when we create a redirect 
handler, the https `ServerConnector` hasn't yet started, so we couldn't get the 
real port from it, it will return -1 as we call `getLocalPort`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to