Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17088#discussion_r103541395
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1331,7 +1332,7 @@ class DAGScheduler(
// TODO: mark the executor as failed only if there were lots of
fetch failures on it
if (bmAddress != null) {
- handleExecutorLost(bmAddress.executorId, filesLost = true,
Some(task.epoch))
+ handleExecutorLost(bmAddress.executorId, slaveLost = true,
Some(task.epoch))
--- End diff --
I'm not sure it's correct to assume that a FetchFailure means that all of
the executors on the slave were lost. You could have a failure because one
executor died, but the other executors on the host are OK, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
