Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/17088#discussion_r103552476
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1331,7 +1332,7 @@ class DAGScheduler(
// TODO: mark the executor as failed only if there were lots of
fetch failures on it
if (bmAddress != null) {
- handleExecutorLost(bmAddress.executorId, filesLost = true,
Some(task.epoch))
+ handleExecutorLost(bmAddress.executorId, slaveLost = true,
Some(task.epoch))
--- End diff --
@kayousterhout - This change applies only when external shuffle service is
enabled, in that case, a fetch failure would mean that the external shuffle
service is unavailable, so we should remove all the output on that host, right?
For case, when shuffle service is not enabled, this change should be a no-op.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
