Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/2379#issuecomment-55776666
  
    @vanzin @witgo Actually my intention was not to put everything you load 
from the properties file into `sys.props`. This is what `SparkSubmit` does, but 
only because it does not have access to the conf that the application will use. 
There are a few places (`Worker`, `Master`, `HistoryServer`) where the way we 
set the properties through `sys.props` right now makes the initialization 
ordering of `SparkConf` and the respective `*Argument` class sensitive. 
Instead, it might be simpler if we do `conf.set` for those places instead (we 
already do this elsewhere in `HistoryServerArgument`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to