Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/2379#issuecomment-55848101
  
    @witgo Not sure if I understand what you mean. The changes I am proposing 
actually changes less code (compared to Spark master), not more. Right now a 
problem in this PR is that the ordering between `new SparkConf` and 
`WorkerArgument` (or other arguments) is changed, but I'm saying it should not 
be. All I'm saying is that within `WorkerArgument`, replace 
`sys.props.getOrElseUpdate` with `conf.setIfMissing`.  Do you understand?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to