Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r105266591
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
@@ -100,6 +100,8 @@ public boolean isFinal() {
/**
* Disconnects the handle from the application, without stopping it.
After this method is called,
* the handle will not be able to communicate with the application
anymore.
+ * Please note if using {@link SparkLauncher#autoShutdown()} option,
this method would shutdown
--- End diff --
Since the first sentence says "without stopping it" perhaps we should
rephrase that line.
Disconnects the handle from the application. If {@link
SparkLauncher#autoShutdown()} is set this will stop the running application
too, otherwise the disconnect does not stop it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
