Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r105259983
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -719,7 +716,24 @@ object SparkSubmit extends CommandLineUtils {
printWarning("Subclasses of scala.App may not work correctly. Use a
main() method instead.")
}
- val mainMethod = mainClass.getMethod("main", new
Array[String](0).getClass)
+ val sparkAppMainMethodArr = mainClass.getMethods().filter(_.getName()
== "sparkMain")
+ val isSparkApp = sparkAppMainMethodArr.length > 0
+
+ val childSparkConf = sysProps.filter( p =>
p._1.startsWith("spark.")).toMap
+
+ // If running sparkApp or in thread mode, the System properties should
not be cluttered.
--- End diff --
can remove "or in thread mode"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
