Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106236820
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -73,6 +74,12 @@
/** Logger name to use when launching a child process. */
public static final String CHILD_PROCESS_LOGGER_NAME =
"spark.launcher.childProcLoggerName";
+ public static final String LAUNCHER_INTERNAL_PORT =
"spark.launcher.internal.port";
--- End diff --
I'm not a fan of having these public variables. This is a public class so
we should try to hide anything that is internal to Spark from the API.
A way of doing this would be to leave this as package-private, and move the
code that connects to the launcher from `Client.scala` to
`YarnCommandBuilderUtils.scala`, since the latter is in the launcher package.
And perhaps rename the latter to `YarnLauncherUtils.scala` since it would be
doing more than just what it does now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
