Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16867#discussion_r106229967
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -141,6 +143,9 @@ private[spark] class TaskSetManager(
// Task index, start and finish time for each task attempt (indexed by
task ID)
val taskInfos = new HashMap[Long, TaskInfo]
+ // Use a MedianHeap to record durations of successful tasks when
speculation is enabled.
--- End diff --
can you expand on this a bit to something like:
// Use a MedianHeap to record durations of successful tasks so we know when
to launch speculative tasks.
// This is only used when speculation is enabled, to avoid the overhead of
inserting into the heap when the
// heap won't be used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
