GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/17326
[SPARK-19985][ML] Fixed copy method for some ML Models
## What changes were proposed in this pull request?
Some ML Models were using `defaultCopy` which expects a default
constructor, and others were not setting the parent estimator. This change
fixes these by creating a new instance of the model and explicitly setting
values and parent.
## How was this patch tested?
Added `MLTestingUtils.checkCopy` to the offending models to tests to verify
the copy is made and parent is set.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BryanCutler/spark
ml-model-copy-error-SPARK-19985
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17326
----
commit dc65b135e3d0110a951888baa7121e93613cda5f
Author: Bryan Cutler <cutl...@gmail.com>
Date: 2017-03-16T22:16:46Z
added regression testing for model copies
commit 89bac8a209ca05bfa58e952a01ef664fe8ae2f65
Author: Bryan Cutler <cutl...@gmail.com>
Date: 2017-03-16T22:59:10Z
fixed copy method for ML models throwing error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
