Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/17326#discussion_r106969492
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala
---
@@ -74,6 +74,7 @@ class MultilayerPerceptronClassifierSuite
.setMaxIter(100)
.setSolver("l-bfgs")
val model = trainer.fit(dataset)
+ MLTestingUtils.checkCopy(model)
--- End diff --
Thanks @hhbyyh , I agree that this is maybe not the best general way to
test it, but this is how it is done in every other `Model` test. Maybe this is
ok for now and we could follow up with a discussion on the best way to check
"basic" ML functionality?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
