Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2436#discussion_r17692494
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -491,14 +491,13 @@ private[spark] class Master(
val shuffledAliveWorkers = Random.shuffle(workers.toSeq.filter(_.state
== WorkerState.ALIVE))
val aliveWorkerNum = shuffledAliveWorkers.size
var curPos = 0
+ var stopPos = aliveWorkerNum
--- End diff --
Won't this result in an infinite loop if no workers are available? `curPos`
is never equal to `aliveWorkerNum`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
