Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/2436#discussion_r17695194 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -490,22 +490,27 @@ private[spark] class Master( // Randomization helps balance drivers val shuffledAliveWorkers = Random.shuffle(workers.toSeq.filter(_.state == WorkerState.ALIVE)) val aliveWorkerNum = shuffledAliveWorkers.size - var curPos = 0 - for (driver <- waitingDrivers.toList) { // iterate over a copy of waitingDrivers - // We assign workers to each waiting driver in a round-robin fashion. For each driver, we - // start from the last worker that was assigned a driver, and continue onwards until we have - // explored all alive workers. - curPos = (curPos + 1) % aliveWorkerNum - val startPos = curPos - var launched = false - while (curPos != startPos && !launched) { - val worker = shuffledAliveWorkers(curPos) - if (worker.memoryFree >= driver.desc.mem && worker.coresFree >= driver.desc.cores) { - launchDriver(worker, driver) - waitingDrivers -= driver - launched = true + + if (aliveWorkerNum > 0) { + var curPos = 0 + var stopPos = aliveWorkerNum --- End diff -- Ah, yes. I'll modify.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org