Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/17297#discussion_r106774683
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -193,13 +193,6 @@ private[spark] class TaskSchedulerImpl
private[scheduler](
val stageTaskSets =
taskSetsByStageIdAndAttempt.getOrElseUpdate(stage, new
HashMap[Int, TaskSetManager])
stageTaskSets(taskSet.stageAttemptId) = manager
- val conflictingTaskSet = stageTaskSets.exists { case (_, ts) =>
--- End diff --
@squito - That's correct, this is checking that we should not have more
than one non-zombie attempts of a stage running. But in the scenario in (d) you
described below, we will end up having more than two non-zombie attempts.
However, my point is there is no reason we should not allow multiple
concurrent attempts of a stage to run, the only thing we should guarantee is we
are running mutually exclusive tasks in those attempts. With this change, since
the dag scheduler already keeps track of submitted/running tasks, it can
guarantee that it will not resubmit duplicate tasks for a stage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
