Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17166#discussion_r107073269
  
    --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
    @@ -212,8 +212,8 @@ case object TaskResultLost extends TaskFailedReason {
      * Task was killed intentionally and needs to be rescheduled.
      */
     @DeveloperApi
    -case object TaskKilled extends TaskFailedReason {
    -  override def toErrorString: String = "TaskKilled (killed intentionally)"
    +case class TaskKilled(reason: String) extends TaskFailedReason {
    +  override def toErrorString: String = s"TaskKilled ($reason)"
    --- End diff --
    
    This is unfortunately not backwards compatible. I've looked into this, but 
the issue seems to be that case objects are not equal to any case class in 
scala. If `TaskKilled` was a case class to start with, compatibility might have 
been possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to