Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107237325
--- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
---
@@ -215,7 +215,8 @@ private[spark] class PythonRunner(
case e: Exception if context.isInterrupted =>
logDebug("Exception thrown after task interruption", e)
- throw new TaskKilledException
+ context.killTaskIfInterrupted()
+ null // not reached
--- End diff --
nit: It would be good if we could directly throw the exception here -
instead of relying on killTaskIfInterrupted to do the right thing (it is
interrupted already according to the case check)
Not only will it not remove the unreachable `null`, but also ensure future
changes to `killTaskIfInterrupted` or interrupt reset, etc does not break this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
