Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17276#discussion_r107160710 --- Diff: core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleWriter.scala --- @@ -72,6 +72,18 @@ private[spark] class SortShuffleWriter[K, V, C]( val partitionLengths = sorter.writePartitionedFile(blockId, tmp) shuffleBlockResolver.writeIndexFileAndCommit(dep.shuffleId, mapId, partitionLengths, tmp) mapStatus = MapStatus(blockManager.shuffleServerId, partitionLengths) + partitionLengths.foreach(writeMetrics.incBlockSizeDistribution(_)) + if (mapStatus.isInstanceOf[HighlyCompressedMapStatus]) { + writeMetrics.setAverageBlockSize( + mapStatus.asInstanceOf[HighlyCompressedMapStatus].getAvgSize()); + (0 until partitionLengths.length).foreach { + case i => + if (partitionLengths(i) < mapStatus.getSizeForBlock(i)) { --- End diff -- don't you want the condition reversed? `partitionLengths(i)` is the true size, so an underestimate is if the mapStatus says the size is smaller.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org