Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/17276#discussion_r107158475
--- Diff:
core/src/main/scala/org/apache/spark/executor/ShuffleReadMetrics.scala ---
@@ -80,13 +92,17 @@ class ShuffleReadMetrics private[spark] () extends
Serializable {
private[spark] def incRemoteBlocksFetched(v: Long): Unit =
_remoteBlocksFetched.add(v)
private[spark] def incLocalBlocksFetched(v: Long): Unit =
_localBlocksFetched.add(v)
private[spark] def incRemoteBytesRead(v: Long): Unit =
_remoteBytesRead.add(v)
+ private[spark] def incRemoteBytesReadToMem(v: Long): Unit =
_remoteBytesReadToMem.add(v)
+ private[spark] def incRemoteBytesReadToDisk(v: Long): Unit =
_remoteBytesReadToDisk.add(v)
--- End diff --
since you are not using this yet, it shouldn't be part of this pr (I
realize you may be using this as part of other changes in your own internal
testing)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
