Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107528253
--- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala ---
@@ -59,8 +59,8 @@ private[spark] class TaskContextImpl(
/** List of callback functions to execute when the task fails. */
@transient private val onFailureCallbacks = new
ArrayBuffer[TaskFailureListener]
- // Whether the corresponding task has been killed.
- @volatile private var interrupted: Boolean = false
+ // If defined, the corresponding task has been killed for the contained
reason.
+ @volatile private var maybeKillReason: Option[String] = None
--- End diff --
How about calling this `reasonIfKilled`, here and elsewhere? (if you
strongly prefer the existing name find to leave as-is -- I just slightly prefer
making it somewhat more obvious that this and the fact that the task has been
killed are tightly intertwined).
In any case, can you expand the comment a bit to one you used below: "If
specified, this task has been killed and this option contains the reason."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
