Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/17166#discussion_r107533097
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -160,15 +160,20 @@ private[spark] abstract class Task[T](
// A flag to indicate whether the task is killed. This is used in case
context is not yet
// initialized when kill() is invoked.
- @volatile @transient private var _killed = false
+ @volatile @transient private var _maybeKillReason: String = null
protected var _executorDeserializeTime: Long = 0
protected var _executorDeserializeCpuTime: Long = 0
/**
* Whether the task has been killed.
*/
- def killed: Boolean = _killed
+ def killed: Boolean = _maybeKillReason != null
+
+ /**
+ * If this task has been killed, contains the reason for the kill.
--- End diff --
As above, can you make the comment "If specified, this task has been killed
and this option contains the reason." (assuming that you get rid of the killed
variable)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
