Github user sethah commented on the issue:
https://github.com/apache/spark/pull/17478
I guess I don't see the harm in keeping these checks. Yes, in this case we
always call `LogisticAggregator` after we have gone through the same data with
`MultivariateOnlineSummarizer`, but it may not always be the case. These checks
are very small computation in comparison with the add and merge operations. I
can imagine future developers finding that these are unchecked in the
aggregator and trying to re-implement this logic.
If this were a performance fix, I'd support it. I don't think it is, and so
I think the code is more readable and clear if we keep the checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
