Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/17478
Thanks for @wangmiao1981 for the PR and @sethah for the comments. Maybe I
should be more clear when I created the jira.
I would prefer to remove the require here permanently.
The relevant operation (especially `add`) could be invoked maybe billions
of times (10M recoreds * 100 iterations) during a training. The check for
feature dimension and weight should only be carried out once. But here they are
conducted in each iteration.
And for the general code practice, I would not keep unnecessary code unless
there's clear plan for it. That's just me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
