Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r109865610
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -386,7 +386,7 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder {
"LOCATION and 'path' in OPTIONS are both used to indicate the
custom table path, " +
"you can only specify one of them.", ctx)
}
- val customLocation = storage.locationUri.orElse(location)
+ val customLocation =
storage.locationUri.orElse(location.map(CatalogUtils.stringToURI(_)))
--- End diff --
In addition, I guess we alway have a lot of tests with URI input paths and
I did many of them to pass the tests on Windows, which I guess implicitly some
committers do not disagree with this.
IMHO, I guess URIs should be supported first correctly and local path
should be supported as abbreviation because those local path form is
abbreviation of the fully qualified path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
