Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r110560960
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
// compatible format, which means the data source is file-based
and must have a `path`.
require(table.storage.locationUri.isDefined,
"External file-based data source table must have a `path` entry
in storage properties.")
- Some(new Path(table.location).toUri.toString)
--- End diff --
I think I have two questions as below:
- Is it okay to use both URIs and local file paths for the input string for
`org.apache.hadoop.fs.Path` in general (when they are expected to be unescaped)?
- What `org.apache.hadoop.fs.Path` expects for input string? It seems URI
strings but with unescaped characters per
https://hadoop.apache.org/docs/stable/api/org/apache/hadoop/fs/Path.html and
there are special cases that requires escaped characters such as s3n/s3a/s3
urls. Is my understanding correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
