Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17330#discussion_r110693397
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
 ---
    @@ -59,6 +58,13 @@ abstract class SubqueryExpression(
             children.zip(p.children).forall(p => p._1.semanticEquals(p._2))
         case _ => false
       }
    +  def canonicalize(attrs: AttributeSeq): SubqueryExpression = {
    +    // Normalize the outer references in the subquery plan.
    +    val subPlan = plan.transformAllExpressions {
    +      case OuterReference(r) => QueryPlan.normalizeExprId(r, attrs)
    --- End diff --
    
    @cloud-fan Actually you r right. Preserving the OuterReference would be 
good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to