Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110976069
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -76,6 +76,13 @@ class CachedTableSuite extends QueryTest with
SQLTestUtils with SharedSQLContext
sum
}
+ private def getNumInMemoryTableScanExecs(plan: SparkPlan): Int = {
--- End diff --
@cloud-fan So we are operating at the physical plan level in this method
where as the other method getNumInMemoryRelations operates at a logical plan
level. And in here we are simply counting the the InMemoryTableScanExec nodes
in the plan. I have changed the function name to
getNumInMemoryTablesRecursively. Does it look ok to you ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
