Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17546#discussion_r111098412
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -327,3 +349,109 @@ object JoinReorderDP extends PredicateHelper with
Logging {
case class Cost(card: BigInt, size: BigInt) {
def +(other: Cost): Cost = Cost(this.card + other.card, this.size +
other.size)
}
+
+/**
+ * Implements optional filters to reduce the search space for join
enumeration.
+ *
+ * 1) Star-join filters: Plan star-joins together since they are assumed
+ * to have an optimal execution based on their RI relationship.
+ * 2) Cartesian products: Defer their planning later in the graph to avoid
--- End diff --
We already have this logic in the dp join reorder algorithm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
